This repository has been archived by the owner on Sep 6, 2023. It is now read-only.
Add None as a valid SameSite value
#32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following cloudflare#12, this PR allows for cookies to have their attribute `SameSite` set to `None`. See: https://tools.ietf.org/html/draft-west-first-party-cookies-07
8 tasks
|
👍 would be great to get this merged soon! |
|
I'm going to comment here in addition to the +1. Chrome is going to start defaulting SameSite to There will probably be more people winding their way in here this week as we scramble to patch this from the Ops side of things. |
|
Thanks for your PR, merged now! Sorry for the slow reply. |
|
Thanks a lot @jdesgats! |
|
@jdesgats when are you planning to release this in Luarocks? |
8 tasks
|
I can tag a release, but we don't officially distribute modules on Luarocks at this time: the module is owned by @calio. |
Merged
8 tasks
|
@ElvinEfendi I added a SCM rockspec in the repo, so you should be able to install the master version with |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #12, this PR allows for cookies to have their attribute
SameSiteset toNone.See: https://tools.ietf.org/html/draft-west-first-party-cookies-07
Chrome will be releasing these changes on February: https://blog.chromium.org/2019/10/developers-get-ready-for-new.html