Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cloudflare_argo_tunnel.tunnel_token exported attribute is not marked as sensitive #2125

Closed
2 tasks done
ruimarinho opened this issue Jan 9, 2023 · 2 comments · Fixed by #2231
Closed
2 tasks done
Labels
kind/bug Categorizes issue or PR as related to a bug. triage/needs-information Indicates an issue needs more information in order to work on it.
Milestone

Comments

@ruimarinho
Copy link
Contributor

ruimarinho commented Jan 9, 2023

Confirmation

  • My issue isn't already found on the issue tracker.
  • I have replicated my issue using the latest version of the provider and it is still present.

Terraform and Cloudflare provider version

Terraform v1.2.4
on darwin_arm64
+ provider registry.terraform.io/cloudflare/cloudflare v3.31.0
+ provider registry.terraform.io/hashicorp/http v3.2.1
+ provider registry.terraform.io/hashicorp/vault v3.12.0

Affected resource(s)

cloudflare_argo_tunnel

Terraform configuration files

resource "cloudflare_argo_tunnel" "vpc_test_01" {
  account_id = cloudflare_account.main.id
  name = "vpc-test-01"
  secret = "foo"
}

Link to debug output

https://gist.github.com/ruimarinho/fc29803fd1bc1240177ed8b05743c976

Panic output

No response

Expected output

-/+ resource "cloudflare_argo_tunnel" "vpc_test_01" {
      ~ cname        = "e2d04e88-142a-471e-b0b6-74d8f9e10083.cfargotunnel.com" -> (known after apply)
      ~ id           = "e2d04e88-142a-471e-b0b6-74d8f9e10083" -> (known after apply)
        name         = "vpc-test-01"
      ~ secret       = (sensitive value) # forces replacement
      ~ tunnel_token = (sensitive value) -> (known after apply)
        # (1 unchanged attribute hidden)
    }

Actual output

-/+ resource "cloudflare_argo_tunnel" "vpc_test_01" {
      ~ cname        = "e2d04e88-142a-471e-b0b6-74d8f9e10083.cfargotunnel.com" -> (known after apply)
      ~ id           = "e2d04e88-142a-471e-b0b6-74d8f9e10083" -> (known after apply)
        name         = "vpc-test-01"
      ~ secret       = (sensitive value) # forces replacement
      ~ tunnel_token = "qhwnsggtjvuksosehibbnjbgcbmwwtcxorlihnbuimwlzfwizwsjdewmknbqgebxyiwzxqggbducczhiipvsmqgrecqruouybxlekfgeozcdkyaustyyhycjhmbmtvociiafiqhlygenosvxurnzoxysqsocckdldhknxfmregepevjmoaprckou" -> (known after apply)
        # (1 unchanged attribute hidden)
    }

Steps to reproduce

Create a cloudflare_argo_tunnel resource and then change its secret to force a recreate action. Run a plan. The previously generated tunnel_token exported attribute is exposed.

Additional factoids

No response

References

No response

@ruimarinho ruimarinho added kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 9, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2023

Thank you for reporting this issue! For maintainers to dig into issues it is required that all issues include the entirety of TF_LOG=DEBUG output to be provided. The only parts that should be redacted are your user credentials in the X-Auth-Key, X-Auth-Email and Authorization HTTP headers. Details such as zone or account identifiers are not considered sensitive but can be redacted if you are very cautious. This log file provides additional context from Terraform, the provider and the Cloudflare API that helps in debugging issues. Without it, maintainers are very limited in what they can do and may hamper diagnosis efforts.

This issue has been marked with triage/needs-information and is unlikely to receive maintainer attention until the log file is provided making this a complete bug report.

@github-actions github-actions bot added triage/needs-information Indicates an issue needs more information in order to work on it. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 9, 2023
@github-actions github-actions bot added this to the v3.35.0 milestone Feb 10, 2023
@github-actions
Copy link
Contributor

This functionality has been released in v3.35.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. triage/needs-information Indicates an issue needs more information in order to work on it.
Projects
None yet
1 participant