-
Notifications
You must be signed in to change notification settings - Fork 630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Rate Limit Docs #292
Comments
It's not this simple unfortunately. Different plans have different limits so the provider validation can only account one of them (which we've chosen as Enterprise as that is the outer limits of all). I don't know how we can better represent this in the documentation without doing something like this for all properties:
I think #174 is the wrong reference here as it's for zone/zone_id changes but updating the |
PR'd the changes the second bit in #293 |
Thanks for this @jacobbednarz! Yeah, was totally wrong as I meant #171 and #172. |
…-ownership-challenge Add OwnershipChallenge token field to LogpushJob struct
Howdy Devs,
Submitting this because I just had very long issue that could've been solved with documentation note, and I can't cut a PR for this.
Could it be updated so that https://github.com/terraform-providers/terraform-provider-cloudflare/blob/master/website/docs/r/rate_limit.html.markdown reflects:
challenge
andchallenge_js
modes for the action block (reflectingAllowEDIT: Add challenge and js_challenge rate-limit modes #172)?zone_id
to setzone
and vice versa #174Thanks,
Jam
The text was updated successfully, but these errors were encountered: