Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Rate Limit Docs #292

Closed
jamfish opened this issue Apr 16, 2019 · 3 comments · Fixed by #293
Closed

Update Rate Limit Docs #292

jamfish opened this issue Apr 16, 2019 · 3 comments · Fixed by #293

Comments

@jamfish
Copy link

jamfish commented Apr 16, 2019

Howdy Devs,

Submitting this because I just had very long issue that could've been solved with documentation note, and I can't cut a PR for this.

Could it be updated so that https://github.com/terraform-providers/terraform-provider-cloudflare/blob/master/website/docs/r/rate_limit.html.markdown reflects:

Thanks,

Jam

@jacobbednarz
Copy link
Member

* That there's set defaults for the 'period' argument (support noted 60, 3600, or 86400 seconds)

It's not this simple unfortunately. Different plans have different limits so the provider validation can only account one of them (which we've chosen as Enterprise as that is the outer limits of all). I don't know how we can better represent this in the documentation without doing something like this for all properties:

Valid values:

  • Enterprise: 10
  • Paid: 5
  • Free: 1
* The `challenge` and `challenge_js` modes for the action block (reflecting #174)?

I think #174 is the wrong reference here as it's for zone/zone_id changes but updating the actions.mode documentation is 👍.

@jacobbednarz
Copy link
Member

PR'd the changes the second bit in #293

@jamfish
Copy link
Author

jamfish commented Apr 22, 2019

Thanks for this @jacobbednarz! Yeah, was totally wrong as I meant #171 and #172.

boekkooi-lengoo pushed a commit to boekkooi-lengoo/terraform-provider-cloudflare that referenced this issue Feb 28, 2022
…-ownership-challenge

Add OwnershipChallenge token field to LogpushJob struct
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants