Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page Rule - Host Header Override #46

Closed
meirf opened this issue Apr 11, 2018 · 10 comments
Closed

Page Rule - Host Header Override #46

meirf opened this issue Apr 11, 2018 · 10 comments

Comments

@meirf
Copy link

meirf commented Apr 11, 2018

Many page rule options are supported, but I don't see anything for overriding host headers.

Was is left out because of a technical reason or because it's perceived as less important than the ones that were implemented?

@prdonahue
Copy link

prdonahue commented Apr 13, 2018

Wasn't intentional. We'll get added in the next revision.

@nmasur
Copy link

nmasur commented May 7, 2018

We're also missing Bypass Cache on Cookie.

@SteveGoldthorpe-Work
Copy link
Contributor

And Resolve Override.

@meirf
Copy link
Author

meirf commented Jun 11, 2018

Steve, thanks for creating a PR for this.

Would anyone like to review it?

@simpsora
Copy link
Contributor

simpsora commented Jul 5, 2018

All three of those options were fixed in https://github.com/terraform-providers/terraform-provider-cloudflare/pull/76 and merged a couple of days ago.

@SteveGoldthorpe-Work
Copy link
Contributor

Yes, nice of them to merge in a brand new PR ignoring existing PRs and not fixing all the issues.

@simpsora
Copy link
Contributor

simpsora commented Jul 5, 2018 via email

@SteveGoldthorpe-Work
Copy link
Contributor

Yip just spotted that. Quality.

@simpsora
Copy link
Contributor

simpsora commented Jul 5, 2018

Opened https://github.com/terraform-providers/terraform-provider-cloudflare/pull/83 to fix the two broken override actions.

@patryk
Copy link
Contributor

patryk commented Jul 5, 2018

Ops! Sorry about that! I recently took maintainership of the project. Will try to be more careful and not that trigger happy.

@patryk patryk closed this as completed Jul 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants