-
Notifications
You must be signed in to change notification settings - Fork 632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Page Rule - Host Header Override #46
Comments
Wasn't intentional. We'll get added in the next revision. |
We're also missing Bypass Cache on Cookie. |
And Resolve Override. |
Steve, thanks for creating a PR for this. Would anyone like to review it? |
All three of those options were fixed in https://github.com/terraform-providers/terraform-provider-cloudflare/pull/76 and merged a couple of days ago. |
Yes, nice of them to merge in a brand new PR ignoring existing PRs and not fixing all the issues. |
It also seems to treat `host_header_override` as an OnOff field rather than a string field :(
|
Yip just spotted that. Quality. |
Opened https://github.com/terraform-providers/terraform-provider-cloudflare/pull/83 to fix the two broken override actions. |
Ops! Sorry about that! I recently took maintainership of the project. Will try to be more careful and not that trigger happy. |
Many page rule options are supported, but I don't see anything for overriding host headers.
Was is left out because of a technical reason or because it's perceived as less important than the ones that were implemented?
The text was updated successfully, but these errors were encountered: