Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page Rules bugfix / enhancements #61

Closed
wants to merge 25 commits into from

Conversation

SteveGoldthorpe-Work
Copy link
Contributor

Fixes issues:

SteveGoldthorpe-Work and others added 25 commits May 15, 2018 15:53
…_override

add resolve_override page_rule action
…ader_override

add host_header_override page_rule action
…ader_override

missing bracket after merge conflict
…cache_on_cookie

Add page rule bypass cache on cookie
page_rules status is active or disabled not paused
@meirf
Copy link

meirf commented Jun 8, 2018

@prdonahue @catsby @grubernaut please take a look.
There are a bunch of commits here but in total the change is quite small.
(My team can't move forward using terraform+cloudflare without Host Header Override.)
Thank you!
Meir

@leandrocostam
Copy link

We are migrating our DNS provider from Route53 to Cloudflare. We are using terraform for that, but I faced some limitation related to S3 buckets once we have custom names for these buckets. Host_header_override is missing in the currect version of Cloudflare provider. We look forward to see this merged.

@simpsora
Copy link
Contributor

simpsora commented Jun 21, 2018

We're also using the changes in this PR (along with some in #68) to start managing our page rules as code, and looking forward to seeing it merged.

Thanks @SteveGoldthorpe-Work!

@meirf
Copy link

meirf commented Jun 21, 2018

@leandrocostam @simpsora I've put in a request to cloudflare support to make this higher priority for them. I encourage y'all to do the same so they have official data in their system of this customer demand.

@SteveGoldthorpe-Work
Copy link
Contributor Author

I've been in contact with Cloudflare's Product Manager for Terraform and they are fully aware of the issues and are currently working on getting development resources the relevant access. This all sounds encouraging.

@simpsora
Copy link
Contributor

simpsora commented Jul 5, 2018

@SteveGoldthorpe-Work some of this has already been merged as part of https://github.com/terraform-providers/terraform-provider-cloudflare/pull/76 -- specifically bypass_cache_on_cookie, host_header_override, and resolve_override.

The other two changes (addition of waf and s/paused/disabled/ are still useful and not present in master. There's someone actively working on this repo now, so hopefully it'll get some traction!

@simpsora
Copy link
Contributor

simpsora commented Jul 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants