Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support CORS settings #473

Closed
analytically opened this issue Sep 20, 2019 · 4 comments · Fixed by #725
Closed

Support CORS settings #473

analytically opened this issue Sep 20, 2019 · 4 comments · Fixed by #725
Labels
workflow/pending-cloudflare-response Indicates an issue or PR requires a response from the Cloudflare team. workflow/pending-upstream-library Indicates an issue or PR requires changes from an upstream library.

Comments

@analytically
Copy link

Currently the Terraform provider doesn't support the CORS settings for a CloudFlare Access application.

image
@jacobbednarz
Copy link
Member

This currently isn’t exposed via the API so we can’t add functionality until that lands. Do you mind raising a support ticket with Cloudflare requesting this?

@jacobbednarz jacobbednarz added workflow/pending-cloudflare-response Indicates an issue or PR requires a response from the Cloudflare team. workflow/pending-upstream-library Indicates an issue or PR requires changes from an upstream library. and removed blocked labels Mar 10, 2020
@jacobbednarz jacobbednarz mentioned this issue Mar 17, 2020
Closed
@jacobbednarz
Copy link
Member

I've opened 1853883 to have this looked at from the Cloudflare side.

@jacobbednarz
Copy link
Member

CORS support has landed in the documentation today so once this is added upstream, we can add the support for it in Terraform.

@jacobbednarz jacobbednarz mentioned this issue Jun 22, 2020
Merged
@jacobbednarz
Copy link
Member

cloudflare/cloudflare-go#485 is implementing this and then we can add Terraform support for it.

jacobbednarz added a commit to jacobbednarz/terraform-provider-cloudflare that referenced this issue Jul 1, 2020
@jacobbednarz
resource/access_application: Add CORS support
653c630 
Updates `cloudflare_access_application` to define the CORS settings
associated with it.

Closes cloudflare#473
@jacobbednarz jacobbednarz mentioned this issue Jul 1, 2020
Merged
boekkooi-lengoo pushed a commit to boekkooi-lengoo/terraform-provider-cloudflare that referenced this issue Feb 28, 2022
@renovate-bot
Update golang.org/x/net commit hash to 3c3fba1 (cloudflare#473)
3fa42c6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
workflow/pending-cloudflare-response Indicates an issue or PR requires a response from the Cloudflare team. workflow/pending-upstream-library Indicates an issue or PR requires changes from an upstream library.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

resource/access_application: Add CORS support jacobbednarz/terraform-provider-cloudflare
2 participants
@analytically @jacobbednarz