Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs for zone cache variants #1454

Merged

Conversation

maleblond
Copy link
Contributor

Follow-up of #1444

I'm unsure if that's the proper way of updating the docs shown at https://registry.terraform.io/providers/cloudflare/cloudflare/latest/docs . I'm also unsure about how to test those changes

@maleblond maleblond force-pushed the maleblond/add-cache-variants-docs branch from eadfafd to 8d10291 Compare February 14, 2022 16:18
@github-actions
Copy link
Contributor

Oops! It looks like no changelog entry is attached to this PR. Please include a release note as described in https://github.com/cloudflare/terraform-provider-cloudflare/blob/master/docs/changelog-process.md.

Example:

```release-note:TYPE
Release note
```

If you do not require a release note to be included, please add the workflow/skip-changelog-entry label.

@jacobbednarz
Copy link
Member

I'm also unsure about how to test those changes

make website will generate the files locally for you to view.

@maleblond
Copy link
Contributor Author

I'm also unsure about how to test those changes

make website will generate the files locally for you to view.

make website fails:

ln -sf ../../../../ext/providers/cloudflare/website/docs <GOPATH>/src/github.com/hashicorp/terraform-website/content/source/docs/providers/cloudflare
ln: <GOPATH>/src/github.com/hashicorp/terraform-website/content/source/docs/providers/cloudflare: No such file or directory

It appears https://github.com/hashicorp/terraform-website/tree/master/content no longer has a source folder

@jacobbednarz
Copy link
Member

It appears https://github.com/hashicorp/terraform-website/tree/master/content no longer has a source folder

😢 i must still have it locally somewhere. there is also https://registry.terraform.io/tools/doc-preview but that only works for the body of the content and not things like the sidebar.

@jacobbednarz jacobbednarz merged commit 03ca854 into cloudflare:master Feb 14, 2022
@jacobbednarz
Copy link
Member

cheers for following up with this one!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants