-
Notifications
You must be signed in to change notification settings - Fork 630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resource/cloudflare_ruleset: rename mitigation_expression
to counting_expression
#1477
Merged
jacobbednarz
merged 2 commits into
master
from
ruleset-rename-rate-limit-expression-field
Feb 25, 2022
Merged
resource/cloudflare_ruleset: rename mitigation_expression
to counting_expression
#1477
jacobbednarz
merged 2 commits into
master
from
ruleset-rename-rate-limit-expression-field
Feb 25, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobbednarz
added
the
workflow/pending-upstream-library
Indicates an issue or PR requires changes from an upstream library.
label
Feb 20, 2022
…ing_expression` Internally, the `mitigation_expression` field has moved to `counting_expression` to better match its use. This updates the schema to reflect those changes and migrate state files to match. Depends on cloudflare/cloudflare-go#808
jacobbednarz
force-pushed
the
ruleset-rename-rate-limit-expression-field
branch
from
February 22, 2022 03:54
e35d6fc
to
bad47f5
Compare
zakcutner
approved these changes
Feb 23, 2022
acceptance tests are all passing
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
workflow/pending-upstream-library
Indicates an issue or PR requires changes from an upstream library.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internally, the
mitigation_expression
field has moved tocounting_expression
to better match its use. This updates the schemato reflect those changes and migrate state files to match.
While technically breaking, there has already been an internal migration performed for the small handful of customers actually relying on this field leaving us to clean up this last piece with a migration.
Depends on cloudflare/cloudflare-go#808