[resource/device_posture_integration] Remove extra id parameters #1504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the terraform-plugin-sdk adds the "id" to the schema when d.SetID is used. therefore, there is no need to have this extra parameter in the schema. The use of this extra id is causing the pulumi schema to pull a duplicate argument ``` sdk/python/pulumi_cloudflare/device_posture_integration.py:377: error: Duplicate argument "id" in function definition ```
|
Oops! It looks like no changelog entry is attached to this PR. Please include a release note as described in https://github.com/cloudflare/terraform-provider-cloudflare/blob/master/docs/changelog-process.md. Example: If you do not require a release note to be included, please add the |
|
i attempted to resolve this for you but your fork does not allow changes from maintainers. instead, here is a patch you can apply and we can get this merged. From d100290c39f762b7943d429f480bd2e3cb7ff865 Mon Sep 17 00:00:00 2001
From: Jacob Bednarz <[email protected]>
Date: Fri, 11 Mar 2022 11:26:03 +1100
Subject: [PATCH] add CHANGELOG entry
---
.changelog/1504.txt | 3 +++
1 file changed, 3 insertions(+)
create mode 100644 .changelog/1504.txt
diff --git .changelog/1504.txt .changelog/1504.txt
new file mode 100644
index 00000000..8b156d0a
--- /dev/null
+++ .changelog/1504.txt
@@ -0,0 +1,3 @@
+```release-note:bug
+resource/cloudflare_device_posture_integration: remove superfluous `id` from schema
+```
--
2.33.0feel free to use it or add your own commit addressing this. |
jacobbednarz
added
the
workflow/pending-op-response
|
Thanks @jacobbednarz - I've just pushed this now - apologies for not having edits switched on on the branch! |
|
np! thanks for the fix. |
jacobbednarz
removed
the
workflow/pending-op-response
|
Thanks for the fix!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the terraform-plugin-sdk adds the "id" to the schema when d.SetID is
used. therefore, there is no need to have this extra parameter in
the schema.
The use of this extra id is causing the pulumi schema to pull a
duplicate argument