Support load balancer origin weights and session affinity #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating the cloudflare-go library brings support for the weight parameter of load balancer origins. This allows configuration of traffic priority to each of the backend origins, which is critical in more complex load balancing setups.
The newer cloudflare-go library supports configuring session affinity values for Cloudflare load balancers. This commit updates the terraform resource to support this field.
ghost
added
the
|
cc @jacobbednarz, @deuill. |
|
LGTM |
jacobbednarz
approved these changes
Nov 14, 2018
There was a problem hiding this comment.
Awesome 🍭 Thanks @patryk. Will think about my additional comment and open an issue if I can think of enough merit to change it 😛
patryk
deleted the
lawrencejones-lawrence-support-load-balancer-weights
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of PR #57, thanks @lawrencejones.