fix(#1578): allow github access groups to be created without a list of teams
#1589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oops! It looks like no changelog entry is attached to this PR. Please include a release note as described in https://github.com/cloudflare/terraform-provider-cloudflare/blob/master/docs/changelog-process.md. Example: If you do not require a release note to be included, please add the |
cmackenzie1
force-pushed
the
cole/1578-github-org-access
branch
from
9fdfc61 to
a48a29c
Compare
cmackenzie1
changed the title
github access groups to be created without a list of teamsgithub access groups to be created without a list of teams
cmackenzie1
force-pushed
the
cole/1578-github-org-access
branch
from
a48a29c to
e3c1211
Compare
cmackenzie1
changed the title
github access groups to be created without a list of teamsgithub access groups to be created without a list of teams
|
@jacobbednarz I took a stab at resolving #1578, mind you this is only my second time updating a terraform provider so go easy on me 🙏 |
|
acceptance tests look good here |
Closed
2 tasks
|
if you add a CHANGELOG entry (notes above from the automation), we can get this merged. |
…t a list of teams Previously, the contents of the `github` block were not serialized to input JSON being sent to the Cloudflare API unless there was at least one team specified, even though the teams field is optional. This commit changes the behavior of the `github` block to create `include`, `require` and `exclude` blocks with github organizations without specifying a list of teams. Testing was done on my personal Cloudflare Zero Trust account. Running `terraform apply` twice still results in "detected" changes even though they have been applied. I think this is related to issue cloudflare#1553.
cmackenzie1
force-pushed
the
cole/1578-github-org-access
branch
from
e3c1211 to
3014f0a
Compare
|
Thanks @jacobbednarz, added the changelog! |
|
This functionality has been released in v3.14.0 of the Terraform Cloudflare Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the contents of the
githubblock were not serialized to input JSON being sent to the Cloudflare API unless there was at least one team specified, even though the teams field is optional.This commit changes the behavior of the
githubblock to createinclude,requireandexcludeblocks with github organizations without specifying a list of teams.Testing was done on my personal Cloudflare Zero Trust account. Running
terraform applytwice still results in "detected" changes even though they have been applied. I think this is related to issue #1553.Closes #1578