-
Notifications
You must be signed in to change notification settings - Fork 632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed documentation error for workers kv import #1595
Conversation
Oops! It looks like no changelog entry is attached to this PR. Please include a release note as described in https://github.com/cloudflare/terraform-provider-cloudflare/blob/master/docs/changelog-process.md. Example:
If you do not require a release note to be included, please add the |
|
||
``` | ||
$ terraform import cloudflare_workers_kv_namespace.example beaeb6716c9443eaa4deef11763ccca6_test-key | ||
$ terraform import cloudflare_workers_kv.example beaeb6716c9443eaa4deef11763ccca6/"test-key" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we don't need the quotes around the last bit here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy to remove the quotes but they are needed when the key has spaces within it.
I am using workers keys to set up redirects and the keys have spaces within them e.g
^/path1/?$ /path-to-go-to
This wouldn't allow me to import my keys unless I quoted them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's likely a shell issue. The importer splits on /
and spaces are fine. I'm not in front of a computer at the moment but I think terraform import resource.foo "abc/key here"
will also work as expected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cheers! I've not tested that but will trust you 😁 I've now removed the quotes.
LGTM, thanks! |
This functionality has been released in v3.15.0 of the Terraform Cloudflare Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
Fixes documentation for workers kv import. Issue #1398