Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix detection of deleted cloudflare_teams_rule #1622

Merged
merged 1 commit into from
May 13, 2022

Conversation

tjstansell
Copy link
Contributor

@tjstansell tjstansell commented May 12, 2022

this should close #1618

@tjstansell tjstansell requested a review from jacobbednarz as a code owner May 12, 2022 15:56
Copy link
Member

@jacobbednarz jacobbednarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i've poked the service team about this as we should be returning a 404 here; not a 400 so in the future, this can become err.NotFoundError() instead.

@jacobbednarz jacobbednarz merged commit 4348620 into cloudflare:master May 13, 2022
@github-actions github-actions bot added this to the v3.15.0 milestone May 13, 2022
@github-actions
Copy link
Contributor

This functionality has been released in v3.15.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

delete fails for cloudflare_teams_rule since v3.11.0
2 participants