Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unexpected crashes when setting target_host_name with a filters attribute #2425

Merged
merged 6 commits into from
May 10, 2023
Merged

fix: unexpected crashes when setting target_host_name with a filters attribute #2425

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5ffd234
fix: unexpected crashes when setting target_host_name with a filters …
atsushii May 9, 2023
1bbbcdc
doc: add target_host_name
atsushii May 9, 2023
602ccd0
fix: target_host_name to target_hostname
atsushii May 9, 2023
751bbd1
fix: target_host_name to target_hostname
atsushii May 9, 2023
99bc8cc
doc: update
atsushii May 9, 2023
869550b
Merge branch 'master' into feature/fix-nortification-policy-hostname
jacobbednarz May 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .changelog/2425.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:bug
resource/cloudflare_notification_policy: Fix unexpected crashes when setting target_hostname with a filters attribute
```
2 changes: 1 addition & 1 deletion docs/resources/notification_policy.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ Optional:
- `services` (Set of String)
- `slo` (Set of String) A numerical limit. Example: `99.9`.
- `status` (Set of String) Status to alert on.
- `target_host` (Set of String) Target host to alert on for dos.
- `target_hostname` (Set of String) Target host to alert on for dos.
- `target_zone_name` (Set of String) Target domain to alert on.
- `zones` (Set of String) A list of zone identifiers.

Expand Down
2 changes: 1 addition & 1 deletion internal/sdkv2provider/schema_cloudflare_notification_policy.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,7 +267,7 @@ func notificationPolicyFilterSchema() *schema.Schema {
Optional: true,
Description: "Target domain to alert on.",
},
"target_host": {
"target_hostname": {
Type: schema.TypeSet,
Elem: &schema.Schema{
Type: schema.TypeString,
Expand Down