Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DLP-1474: Predefined profiles must be imported for use #2955

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

jongiddy
Copy link
Contributor

Predefined DLP profiles cannot be created. They must be imported to use them. Modify the example code to show this.

@jongiddy jongiddy marked this pull request as ready for review November 21, 2023 10:35
Copy link
Contributor

Oops! It looks like no changelog entry is attached to this PR. Please include a release note as described in https://github.com/cloudflare/terraform-provider-cloudflare/blob/master/contributing/changelog-process.md.

Example:

```release-note:TYPE
Release note
```

If you do not require a release note to be included and you have permission, please add the workflow/skip-changelog-entry label. Otherwise, a maintainer will add the label or ask you for one when they review the PR.

@jacobbednarz
Copy link
Member

thanks for the PR! unfortunately, the file you've edited is a generated artifact of the documentation process. to see how to make changes to the documentation, you're best to check out https://github.com/cloudflare/terraform-provider-cloudflare/blob/master/contributing/registry-documentation.md

additionally, instead of including the import blocks (which are terraform 1.5+ only), can we add a note to the import example? or a note in the docs themselves?

@jongiddy jongiddy force-pushed the DLP-1474 branch 3 times, most recently from 7c57758 to 35a9a88 Compare November 22, 2023 09:50
@jongiddy
Copy link
Contributor Author

Updated to modify resource.tf

@jacobbednarz jacobbednarz merged commit 90212f8 into cloudflare:master Nov 22, 2023
2 of 3 checks passed
@jacobbednarz
Copy link
Member

thanks!

@github-actions github-actions bot added this to the v4.20.0 milestone Nov 22, 2023
Copy link
Contributor

This functionality has been released in v4.20.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants