-
Notifications
You must be signed in to change notification settings - Fork 632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create origin ca data source #2961
Create origin ca data source #2961
Conversation
changelog detected ✅ |
b568b41
to
460274d
Compare
the framework structure is individual packages so you need to reference it appropriately for it to run them. examples:
|
How does this work when we’re talking a resource in sdk and data source in framework? Does the resource have to be migrated? |
internal/framework/service/origin_ca_certificate/data_source_test.go
Outdated
Show resolved
Hide resolved
Co-authored-by: Jacob Bednarz <[email protected]>
Co-authored-by: Jacob Bednarz <[email protected]>
these aren't a part of the API response once the certificate exists
Co-authored-by: Jacob Bednarz <[email protected]>
they don't have to be in the same plugin for actually using it. they are only treated differently internally and running tests. i went ahead and updated the schema and tests here to get it working. on the schema side,
|
makes sense. I totally just copy pasta’d those, trying to get it to run, so thanks for making the code not suck so much! |
thanks for getting this one over the line! 🏅 |
This functionality has been released in v4.20.0 of the Terraform Cloudflare Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I love the upgrade to Framework!
testing notes
When creating the data source, I am unable to run the tests though because the provider isn't aware of the resource. Is there some sort of merge process? Do the resources have to be moved too? Happy to do the legwork, just looking for what’s you’ve done in the past.
Close #2526