Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/cloudflare_custom_pages: Remove always_online #3117

Merged
merged 1 commit into from
Feb 12, 2024
Merged

resource/cloudflare_custom_pages: Remove always_online #3117

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .changelog/3117.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:breaking-change
resource/cloudflare_custom_pages: Removed the `always_online` variant. This page is never generated anymore, if a requested page is unavailable in the archive the error page that would have been shown if always online wasn't enabled is shown.
```
2 changes: 1 addition & 1 deletion docs/resources/custom_pages.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ resource "cloudflare_custom_pages" "example" {

### Required

- `type` (String) The type of custom page you wish to update. Available values: `basic_challenge`, `waf_challenge`, `waf_block`, `ratelimit_block`, `country_challenge`, `ip_block`, `under_attack`, `500_errors`, `1000_errors`, `always_online`, `managed_challenge`.
- `type` (String) The type of custom page you wish to update. Available values: `basic_challenge`, `waf_challenge`, `waf_block`, `ratelimit_block`, `country_challenge`, `ip_block`, `under_attack`, `500_errors`, `1000_errors`, `managed_challenge`.
- `url` (String) URL of where the custom page source is located.

### Optional
Expand Down
2 changes: 0 additions & 2 deletions internal/sdkv2provider/schema_cloudflare_custom_pages.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ func resourceCloudflareCustomPagesSchema() map[string]*schema.Schema {
"under_attack",
"500_errors",
"1000_errors",
"always_online",
"managed_challenge",
}, true),
Description: fmt.Sprintf("The type of custom page you wish to update. %s", renderAvailableDocumentationValuesStringSlice([]string{
Expand All @@ -48,7 +47,6 @@ func resourceCloudflareCustomPagesSchema() map[string]*schema.Schema {
"under_attack",
"500_errors",
"1000_errors",
"always_online",
"managed_challenge",
})),
},
Expand Down
Loading