Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safely deprecate value #3674

Merged
merged 2 commits into from
Aug 20, 2024
Merged

Safely deprecate value #3674

merged 2 commits into from
Aug 20, 2024

Conversation

mgirouard
Copy link
Contributor

This patch follows up #3590 by allowing value to continue be set while still preserving it's deprecated status.

value and content are mutually exclusive. Setting both will return an error.

│ Error: 'content' (present: true) must not be set with 'value' (present: true)

No state changes will take place when replacing value with content provided the value is identical.

This patch follows up cloudflare#3590 by allowing `value` to continue be set while still
preserving it's deprecated status.

`value` and `content` are mutually exclusive. Setting both will return an
error.

    │ Error: 'content' (present: true) must not be set with 'value' (present: true)

No state changes will take place when replacing `value` with `content` provided
the value is identical.
Copy link
Contributor

github-actions bot commented Aug 18, 2024

changelog detected ✅

@bruceoutdoors
Copy link

LGTM!

@mgirouard mgirouard requested a review from musa-cf August 19, 2024 13:04
Copy link

@musa-cf musa-cf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mgirouard mgirouard merged commit d981d08 into cloudflare:master Aug 20, 2024
9 checks passed
@github-actions github-actions bot added this to the v4.40.0 milestone Aug 20, 2024
Copy link
Contributor

This functionality has been released in v4.40.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants