Bugfix: browser_cache_ttl is incorrectly sent as a string when unchanged

[stevehodgkiss]

Fixes an issue added in https://github.com/terraform-providers/terraform-provider-cloudflare/pull/379 where changing an unrelated value will result in browser_cache_ttl being sent as a string rather than an integer. The error message returned from CloudFlare is "TTL values must be whole numbers only". Removing the changed from the conditional fixes that.

[jacobbednarz]

Looking at this a little closer, this might be covering up an issue not fixing the underlying cause. My thinking here is that we shouldn't ever be sending the value to the remote unless it has changed (where "changed" is new or updated). changed is assigned to the result of HasChange() which should take care of diffing the old and new results.

The error message returned from CloudFlare is "TTL values must be whole numbers only".

For anyone following along at home, this issue in the payload is that we are sending the value back as a string when it's intending to be an integer.

# good payload
{
	"targets": [{
		"target": "url",
		"constraint": {
			"operator": "matches",
			"value": "terraform-test.example.com"
		}
	}],
	"actions": [{
		"id": "browser_cache_ttl",
		"value": 1
	}],
	"priority": 1,
	"status": "active",
	"modified_on": "0001-01-01T00:00:00Z",
	"created_on": "0001-01-01T00:00:00Z"
}

# bad payload
{
	"targets": [{
		"target": "url",
		"constraint": {
			"operator": "matches",
			"value": "terraform-test.example.com"
		}
	}],
	"actions": [{
		"id": "browser_cache_ttl",
		"value": "1"
	}],
	"priority": 1,
	"status": "active",
	"modified_on": "0001-01-01T00:00:00Z",
	"created_on": "0001-01-01T00:00:00Z"
}

I'll have a dig around and see why the value is being sent when it hasn't changed.

[jacobbednarz]

Ignore me, I was thinking of another issue which is unrelated.

Happy to 🚢 , just waiting on integration to finish.

[jacobbednarz]

CI has 3 failures at the moment but look unrelated.

TestAccCloudflareWorkerRoute_MultiScriptEnt 
TestAccCloudflareWorkerRoute_SingleScriptEnt 
TestAccCloudflareWorkerRoute_SingleScriptNonEnt

I'll investigate these separately.

[jacobbednarz]

Thanks a bunch @stevehodgkiss! 🎈