-
Notifications
You must be signed in to change notification settings - Fork 632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrate api_shield_operation to framework #4894
migrate api_shield_operation to framework #4894
Conversation
changelog detected ✅ |
23e3a5e
to
d7c2be0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, left one comment, though.
(I can't approve because of lack access)
d7c2be0
to
595774b
Compare
acceptance tests all passing
|
Thanks @jacobbednarz |
This functionality has been released in v4.51.0 of the Terraform Cloudflare Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
This PR migrates
cloudflare_api_shield_operation
to theterraform-plugin-framework
to fix a bug caused by the API returning a normalized version of a specified attribute that causes mismatches between resource config and state, resulting in the resource having to be recreated on everyterraform apply
. This is due to not following the expectations of terraform mentioned in https://github.com/hashicorp/terraform/blob/main/docs/resource-instance-change-lifecycle.md:Migrating to the framework is necessary to implement semantic equality between the unnormalized config and the normalized state returned from the API which is used during
terraform plan/apply
.