Custom Hostnames Resource #580
Conversation
ghost
added
the
| return resourceCloudflareCustomHostnamesRead(d, meta) | ||
| } | ||
|
|
||
| func resourceCloudflareCustomHostnamesRead(d *schema.ResourceData, meta interface{}) error { |
There was a problem hiding this comment.
Why aren't the ssl option changes reflected in the Read? If the remote changes them for any reason, it's not reflected here.
| resource.TestCheckResourceAttr( | ||
| resourceName, "hostname", "[email protected]"), | ||
| resource.TestCheckResourceAttr( | ||
| resourceName, "ssl.custom_hostname_settings.tls13", "on"), |
There was a problem hiding this comment.
Have you run these integration tests? A TypeList is sequentially indice based which means these nested values should have an index in front of them.
|
Developing of this PR on hold at the moment due changes on the custom hostname planned for the end of February, to restart next month with the changes needed and adapted to the new model |
jacobbednarz
added
the
workflow/pending-contributor-response
|
@pcaminog did those changes end up happening? Is there anything stopping this from going in now? |
|
Has this been progressed at all? |
|
@pcaminog @jacobbednarz Has there been any progress on this by chance? |
|
#746 landed so we can close this one and revisit if there are improvements to be made in a separate PR. Thanks! |
New Resource created for support Custom Hostnames in Terraform
This is pending of this PR cloudflare/cloudflare-go#407 to make the update function works.