cloudflare_access_rule: add validation to discover errors during planning phase

[freddierice]

The goal of this PR is to discover preventable mistakes during a terraform plan rather than an apply. Specifically, preventing developers from attempting to apply non /24 and /32 ip_ranges, resulting in partial changes and leaving them exposed.

I didn't create an issue because writing the code took about the same time as describing the problem. I'm open to other solutions.

[jacobbednarz]

I don't mind the change, however, the test included here doesn't excercise the code path it intends to.

With the schema validation commented out, it still passes.

diff --git cloudflare/resource_cloudflare_access_rule.go cloudflare/resource_cloudflare_access_rule.go
index 910c84d..4ddd5a2 100644
--- cloudflare/resource_cloudflare_access_rule.go
+++ cloudflare/resource_cloudflare_access_rule.go
@@ -42,7 +42,7 @@ func resourceCloudflareAccessRule() *schema.Resource {
                                Required:         true,
                                ForceNew:         true,
                                DiffSuppressFunc: configurationDiffSuppress,
-                               ValidateFunc:     validateAccessRuleConfiguration,
+                               // ValidateFunc:     validateAccessRuleConfiguration,
                                Elem: &schema.Resource{
                                        Schema: map[string]*schema.Schema{
                                                "target": {

=== RUN   TestValidateAccessRuleConfigurationIPRange
--- PASS: TestValidateAccessRuleConfigurationIPRange (0.00s)
PASS
ok  	github.com/cloudflare/terraform-provider-cloudflare/cloudflare	0.471s

[freddierice]

Thanks for the review! I fixed the bitmask bug and added a new test to make sure that commenting out the validator will result in a failed test.

[jacobbednarz]

Nice one, thanks for this! 🥇

[jacobbednarz]

this has been released in v2.18.0