Implement cross-language await syntax for KJ Promises and Rust Futures #3280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This gives us Waker::data() and Waker::vtable().
harrishancock
force-pushed
the
harris/rust-async
branch
6 times, most recently
from
e12bca1 to
317008e
Compare
harrishancock
force-pushed
the
harris/rust-async
branch
from
317008e to
dc5479b
Compare
|
Would it be reasonable to request a README.md on the src/rust/async directory explaining what we're doing, the approach and maybe pointers as to how to understand the code? Which part interacts with which and in what way? |
|
Definitely! I won't ask for review until code comments are fleshed out, and I have an explainer written. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.