Run Python tests under asan with leak san disabled. #3304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dom96
force-pushed
the
dominik/only-leak-san
branch
3 times, most recently
from
d1d6ca5 to
8d9575b
Compare
dom96
changed the title
dom96
force-pushed
the
dominik/only-leak-san
branch
from
8d9575b to
b4381a1
Compare
fhanau
reviewed
Jan 9, 2025
| @@ -63,6 +63,9 @@ def _wd_test_impl(ctx): | |||
| # can't just specify some other executable with some args. OK, fine, we'll use a script that | |||
| # just execs its args. | |||
| if is_windows: | |||
| if len(ctx.attr.env): | |||
There was a problem hiding this comment.
This will just make the Windows build fail right? Instead, you could use target_compatible_with to mark targets as incompatible with Windows if env is set
There was a problem hiding this comment.
Well, just passing env on non-Windows is probably easier and avoids just skipping the tests on Windows (assuming we won't have windows-asan in the future).
|
Looks like the tests are just segfaulting instead unfortunately. |
|
Huh, that's interesting. It doesn't happen when run via |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests are currently failing on shutdown due to a memory leak. This PR re-enables them on ASAN without the leak sanitizer to get some coverage under ASAN for them.