-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support for the Cache api #182
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a "caches" type that you can only access from the worker global scope in worker-sys so that hopefully wasm-bindgen will understand what i want. The abstractions in the higher level crate are for "Cache", so you never interact with the JS global directly, and instead instantiate a cache either by name (with a String) or with the `Default` trait, which returns the global default cache.
The js api accepts strings and converts them into the URL for new GET requests. By introducing the `CacheKey` type we can replicate this behavior in rust. Also, added some docs just ripped from https://developers.cloudflare.com/workers/runtime-apis/cache and slightly modified for rust.
so it plays nicer with rust-analyzer etc.
…n store a response in the cache and then return it to the client
This reverts commit fe64154.
Added a "caches" type that you can only access from the worker global scope in worker-sys so that hopefully wasm-bindgen will understand what i want. The abstractions in the higher level crate are for "Cache", so you never interact with the JS global directly, and instead instantiate a cache either by name (with a String) or with the `Default` trait, which returns the global default cache.
The js api accepts strings and converts them into the URL for new GET requests. By introducing the `CacheKey` type we can replicate this behavior in rust. Also, added some docs just ripped from https://developers.cloudflare.com/workers/runtime-apis/cache and slightly modified for rust.
so it plays nicer with rust-analyzer etc.
…n store a response in the cache and then return it to the client
This reverts commit fe64154.
# Conflicts: # worker-sys/src/global.rs # worker-sys/src/lib.rs # worker/src/lib.rs
…rkers-rs into frank/cass/cache-api
Closed
Can I get a published version for this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finally adds support for the Cache api.
This is a continuation of #67 and #175