Skip to content

Commit

Permalink
C3-name-validation-fix (#3496)
Browse files Browse the repository at this point in the history
* Remove package-lock.json, which should be handled at the root

* [C3] fix: ensure that default project name can be used

If you hit enter when asked for the name of the project, you expect it
to use the default value. But the project name validation was then failing
as it was receiving undefined for the value of the input rather than the
default value.

Now the validator will be passed the default if no value was provided.
  • Loading branch information
petebacondarwin authored Jun 20, 2023
1 parent 9fd12df commit 91135e0
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 5,370 deletions.
12 changes: 12 additions & 0 deletions .changeset/nasty-cows-talk.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
---
"create-cloudflare": patch
---

fix: ensure that default project name can be used

If you hit enter when asked for the name of the project, you expect it
to use the default value. But the project name validation was then failing
as it was receiving undefined for the value of the input rather than the
default value.

Now the validator will be passed the default if no value was provided.
Loading

0 comments on commit 91135e0

Please sign in to comment.