Skip to content

Commit

Permalink
ci: ensure E2E tests failures not reported as successes
Browse files Browse the repository at this point in the history
#4458 accidentally left `continue-on-error: true` in the workflow.
This meant that E2E test failures weren't reported as check failures.
  • Loading branch information
mrbbot committed Feb 2, 2024
1 parent e1b7771 commit a4215e9
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions .github/workflows/e2e.yml
Original file line number Diff line number Diff line change
Expand Up @@ -74,8 +74,6 @@ jobs:
run: echo "dir=$(ls $HOME/wrangler-*.tgz)" >> $GITHUB_OUTPUT;

- name: Run tests
id: e2e-1
continue-on-error: true
run: pnpm run --filter wrangler test:e2e
env:
CLOUDFLARE_API_TOKEN: ${{ secrets.TEST_CLOUDFLARE_API_TOKEN }}
Expand Down

0 comments on commit a4215e9

Please sign in to comment.