Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚀 Feature: Source code wrangler init --from-dash #1624

Closed
JacobMGEvans opened this issue Aug 5, 2022 · 1 comment · Fixed by #1645 or #1661
Closed

🚀 Feature: Source code wrangler init --from-dash #1624

JacobMGEvans opened this issue Aug 5, 2022 · 1 comment · Fixed by #1645 or #1661
Assignees
@JacobMGEvans
Labels
enhancement New feature or request

Comments

@JacobMGEvans
Copy link
Contributor

JacobMGEvans commented Aug 5, 2022 •
edited
Loading

Describe the solution

Implement the first phase of --from-dash, getting the source code into an initialized project replacing the boilerplate code.

Additional discussion: #1623

  • This implementation should be agnostic from any source control & storage.
  • Encourage augmenting projects, i.e. TypeScript, and source storage (we currently provide GitHub repo creation).
  • The flag should only be done in empty projects.
@JacobMGEvans JacobMGEvans added the enhancement New feature or request label Aug 5, 2022
@JacobMGEvans JacobMGEvans self-assigned this Aug 5, 2022
@JacobMGEvans JacobMGEvans moved this to Untriaged in workers-sdk Aug 5, 2022
@JacobMGEvans JacobMGEvans moved this from Untriaged to In Progress in workers-sdk Aug 5, 2022
@lrapoport-cf
Copy link
Contributor

for posterity, leaving a note after chatting with @JacobMGEvans : would be awesome to have multipart parsing support in undici

@JacobMGEvans JacobMGEvans linked a pull request Aug 11, 2022 that will close this issue
🚀 feat: download of Worker script --from-dash #1645
Merged
4 tasks
JacobMGEvans added a commit that referenced this issue Aug 11, 2022
@JacobMGEvans
feat: download of Worker script
ad7c13a 
Added the --from-dash <worker-name>, getting the source code into an initialized project replacing the template script.

Resolves #1624
Discussion: #1623
notes: Workaround for handling multipart/form-data slicing off top and bottom boundaries.
multipart/formdata parsing not supported currently in Undici nodejs/undici#974
JacobMGEvans added a commit that referenced this issue Aug 11, 2022
@JacobMGEvans
feat: download of Worker script
19be735 
Added the --from-dash <worker-name>, getting the source code into an initialized project replacing the template script.

Resolves #1624
Discussion: #1623
notes: Workaround for handling multipart/form-data slicing off top and bottom boundaries.
multipart/formdata parsing not supported currently in Undici nodejs/undici#974
JacobMGEvans added a commit that referenced this issue Aug 12, 2022
@JacobMGEvans
feat: download of Worker script
30546db 
Added the --from-dash <worker-name>, getting the source code into an initialized project replacing the template script.

Resolves #1624
Discussion: #1623
notes: Workaround for handling multipart/form-data slicing off top and bottom boundaries.
multipart/formdata parsing not supported currently in Undici nodejs/undici#974
JacobMGEvans added a commit that referenced this issue Aug 12, 2022
@JacobMGEvans
feat: download & initialize a wrangler project from dashboard worker
f514540 
Added `wrangler init --from-dash <worker-name>`, which allows initializing a wrangler project from a pre-existing worker in the dashboard.

Resolves #1624
Discussion: #1623

Notes: `multiplart/form-data` parsing is [not currently supported in Undici](nodejs/undici#974), so a temporary workaround to slice off top and bottom boundaries is in place.
JacobMGEvans added a commit that referenced this issue Aug 12, 2022
@JacobMGEvans
feat: download & initialize a wrangler project from dashboard worker (#…
ac39748 
…1645)

Added `wrangler init --from-dash <worker-name>`, which allows initializing a wrangler project from a pre-existing worker in the dashboard.

Resolves #1624
Discussion: #1623

Notes: `multiplart/form-data` parsing is [not currently supported in Undici](nodejs/undici#974), so a temporary workaround to slice off top and bottom boundaries is in place.
Repository owner moved this from In Progress to Done in workers-sdk Aug 12, 2022
This was referenced Aug 12, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JacobMGEvans JacobMGEvans

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
2 participants
@JacobMGEvans @lrapoport-cf