Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add missing pages-functions-wasm-app deps in package-lock.json #2588

Merged
merged 1 commit into from
Jan 23, 2023

Conversation

CarmenPopoviciu
Copy link
Contributor

@CarmenPopoviciu CarmenPopoviciu commented Jan 23, 2023

What this PR solves / how to test:
Merging #2554 seems to have broken CI
https://github.com/cloudflare/wrangler2/actions/runs/3986649825/jobs/6835473536, so this PR attempts to fix that

Associated docs issues/PR:

  • [insert associated docs issue(s)/PR(s)]

Author has included the following, where applicable:

  • Tests
  • Changeset

Reviewer has performed the following, where applicable:

  • Checked for inclusion of relevant tests
  • Checked for inclusion of a relevant changeset
  • Checked for creation of associated docs updates
  • Manually pulled down the changes and spot-tested

Fixes # [insert issue number].

@CarmenPopoviciu CarmenPopoviciu requested a review from a team as a code owner January 23, 2023 13:28
@changeset-bot
Copy link

changeset-bot bot commented Jan 23, 2023

⚠️ No Changeset found

Latest commit: 1d1121a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jan 23, 2023

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/runs/3987221098/npm-package-wrangler-2588

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/prs/2588/npm-package-wrangler-2588

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/runs/3987221098/npm-package-wrangler-2588 dev path/to/script.js
Additional artifacts:
npm install https://prerelease-registry.devprod.cloudflare.dev/runs/3987221098/npm-package-cloudflare-pages-shared-2588

@codecov
Copy link

codecov bot commented Jan 23, 2023

Codecov Report

Merging #2588 (1d1121a) into main (fbeaf60) will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2588      +/-   ##
==========================================
+ Coverage   73.32%   73.35%   +0.03%     
==========================================
  Files         159      159              
  Lines        9800     9800              
  Branches     2583     2583              
==========================================
+ Hits         7186     7189       +3     
+ Misses       2614     2611       -3     
Impacted Files Coverage Δ
packages/wrangler/src/git-client.ts 81.25% <0.00%> (+4.16%) ⬆️
...ackages/wrangler/src/__tests__/helpers/mock-bin.ts 100.00% <0.00%> (+5.26%) ⬆️

@CarmenPopoviciu
Copy link
Contributor Author

@petebacondarwin any idea why this wasn't caught in my original PR? both devtools.yml and pullrequests.yml seem to run the same npm ci command

@CarmenPopoviciu CarmenPopoviciu force-pushed the pages-dev-experimental-worker-bundle branch from aa02a12 to 7092701 Compare January 23, 2023 13:51
@CarmenPopoviciu CarmenPopoviciu force-pushed the pages-dev-experimental-worker-bundle branch from 7092701 to 1d1121a Compare January 23, 2023 14:12
@CarmenPopoviciu CarmenPopoviciu merged commit e6c9c5c into main Jan 23, 2023
@CarmenPopoviciu CarmenPopoviciu deleted the pages-dev-experimental-worker-bundle branch January 23, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants