-
Notifications
You must be signed in to change notification settings - Fork 778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add missing pages-functions-wasm-app
deps in package-lock.json
#2588
Conversation
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/runs/3987221098/npm-package-wrangler-2588 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/prs/2588/npm-package-wrangler-2588 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/runs/3987221098/npm-package-wrangler-2588 dev path/to/script.js Additional artifacts:npm install https://prerelease-registry.devprod.cloudflare.dev/runs/3987221098/npm-package-cloudflare-pages-shared-2588 |
Codecov Report
@@ Coverage Diff @@
## main #2588 +/- ##
==========================================
+ Coverage 73.32% 73.35% +0.03%
==========================================
Files 159 159
Lines 9800 9800
Branches 2583 2583
==========================================
+ Hits 7186 7189 +3
+ Misses 2614 2611 -3
|
@petebacondarwin any idea why this wasn't caught in my original PR? both |
aa02a12
to
7092701
Compare
7092701
to
1d1121a
Compare
What this PR solves / how to test:
Merging #2554 seems to have broken CI
https://github.com/cloudflare/wrangler2/actions/runs/3986649825/jobs/6835473536, so this PR attempts to fix that
Associated docs issues/PR:
Author has included the following, where applicable:
Reviewer has performed the following, where applicable:
Fixes # [insert issue number].