-
Notifications
You must be signed in to change notification settings - Fork 786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update miniflare dependency to resolve HTTPS bug on Windows #3352
fix: update miniflare dependency to resolve HTTPS bug on Windows #3352
Conversation
🦋 Changeset detectedLatest commit: 51e0d8f The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/5089773772/npm-package-wrangler-3352 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/3352/npm-package-wrangler-3352 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/5089773772/npm-package-wrangler-3352 dev path/to/script.js Additional artifacts:npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/5089773772/npm-package-cloudflare-pages-shared-3352 Note that these links will no longer work once the GitHub Actions artifact expires. |
Codecov Report
@@ Coverage Diff @@
## main #3352 +/- ##
==========================================
+ Coverage 75.40% 75.43% +0.02%
==========================================
Files 181 181
Lines 11044 11044
Branches 2896 2896
==========================================
+ Hits 8328 8331 +3
+ Misses 2716 2713 -3 |
I applied this patch locally and can confirm it fixed #3264 for me! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we bump the version constraints in package.json
files too? This will force upgrade the Miniflare version when users upgrade Wrangler. Currently, it's ^3.0.0
which is still valid for 3.0.0
. I'd find/replace "miniflare": "^3.0.0"
in package.json
files to ^3.0.1
.
Closing in favour of #3454 |
Closes #3264
Closes #3218
Reviewer is to perform the following, as applicable: