-
Notifications
You must be signed in to change notification settings - Fork 779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add 24h read/write metrics to d1 info #3434
Conversation
🦋 Changeset detectedLatest commit: 9bd778f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/5255000265/npm-package-wrangler-3434 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/3434/npm-package-wrangler-3434 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/5255000265/npm-package-wrangler-3434 dev path/to/script.js Additional artifacts:npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/5255000265/npm-package-cloudflare-pages-shared-3434 Note that these links will no longer work once the GitHub Actions artifact expires. |
Codecov Report
@@ Coverage Diff @@
## main #3434 +/- ##
==========================================
- Coverage 75.32% 75.21% -0.11%
==========================================
Files 183 183
Lines 11022 11052 +30
Branches 2893 2904 +11
==========================================
+ Hits 8302 8313 +11
- Misses 2720 2739 +19
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rozenmd - should we change file_size
to something clearer - e.g. database_size
- ?
Since file_size
implies a single file/isn't a term we use elsewhere when talking about D1.
Otherwise: LGTM!
output for experimental dbs: