Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

c3: add new Queues and Cron Triggers templates #3474

Merged
merged 7 commits into from
Jun 19, 2023

Conversation

elithrar
Copy link
Contributor

@elithrar elithrar commented Jun 15, 2023

This PR adds new templates for:

  • Queues, including both producer and consumer example handlers
  • Scheduled Workers (Cron Triggers)

It also:

  • Renames the "Common Worker functions" to a more descriptive "Example router & proxy Worker" (which is what it is)
  • Adds both queues and scheduled to the e2e test harness.

This makes it easier for developers to get started and surfaces more Developer Platform products/features when first starting out via C3.

image

@elithrar elithrar added the c3 Relating to C3 (create-cloudflare) package label Jun 15, 2023
@elithrar elithrar self-assigned this Jun 15, 2023
@changeset-bot
Copy link

changeset-bot bot commented Jun 15, 2023

🦋 Changeset detected

Latest commit: 6869390

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-cloudflare Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jun 15, 2023

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/5311342506/npm-package-wrangler-3474

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/3474/npm-package-wrangler-3474

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/5311342506/npm-package-wrangler-3474 dev path/to/script.js
Additional artifacts:
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/5311342506/npm-package-cloudflare-pages-shared-3474

Note that these links will no longer work once the GitHub Actions artifact expires.

@codecov
Copy link

codecov bot commented Jun 15, 2023

Codecov Report

Merging #3474 (37943a5) into main (78042c8) will increase coverage by 0.09%.
The diff coverage is n/a.

❗ Current head 37943a5 differs from pull request most recent head 6869390. Consider uploading reports for the commit 6869390 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3474      +/-   ##
==========================================
+ Coverage   75.18%   75.28%   +0.09%     
==========================================
  Files         183      183              
  Lines       11055    11034      -21     
  Branches     2904     2902       -2     
==========================================
- Hits         8312     8307       -5     
+ Misses       2743     2727      -16     

see 5 files with indirect coverage changes

@elithrar elithrar requested review from a team as code owners June 15, 2023 22:57
@elithrar
Copy link
Contributor Author

Incorporated Adam's suggestions + added a changeset.

@elithrar elithrar merged commit a72dc0a into main Jun 19, 2023
@elithrar elithrar deleted the silverlock/c3/queues-cron-templates branch June 19, 2023 11:39
@github-actions github-actions bot mentioned this pull request Jun 19, 2023
lrapoport-cf pushed a commit that referenced this pull request Aug 11, 2023
* c3: add new Queues and Cron Triggers templates

* c3: fix formatting

* c3: rename scheduled; add tests; update common desc

* Update packages/create-cloudflare/e2e-tests/workers.test.ts

Co-authored-by: Adam Murray <[email protected]>

* c3: Apply suggestions from code review

Co-authored-by: Adam Murray <[email protected]>

* c3: add changeset

* c3: fix comments

---------

Co-authored-by: Adam Murray <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c3 Relating to C3 (create-cloudflare) package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants