Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update link to template directory for wrangler -h #3724

Merged
merged 2 commits into from
Dec 11, 2023

Conversation

mschumacher-cf
Copy link
Contributor

What this PR solves / how to test:

When running wrangler -h (version 3.5.0) the link to the template directory is https://github.com/cloudflare/templates. This repo is archived and points to https://github.com/cloudflare/workers-sdk in its README which in turn contains a templates directory. I have updated the link to point to the new templates directory.

Associated docs issue(s)/PR(s):

  • [insert associated docs issue(s)/PR(s)]

Author has included the following, where applicable:

  • Tests

Reviewer is to perform the following, as applicable:

  • Checked for inclusion of relevant tests
  • Manually pulled down the changes and spot-tested

@mschumacher-cf mschumacher-cf requested a review from a team as a code owner August 9, 2023 10:15
@changeset-bot
Copy link

changeset-bot bot commented Aug 9, 2023

⚠️ No Changeset found

Latest commit: 4fb29f9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2023

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7089482620/npm-package-wrangler-3724

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7089482620/npm-package-wrangler-3724

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7089482620/npm-package-wrangler-3724 dev path/to/script.js
Additional artifacts:
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7089482620/npm-package-miniflare-3724
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7089482620/npm-package-cloudflare-pages-shared-3724
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7089482620/npm-package-create-cloudflare-3724

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20231030.2
workerd 1.20231030.0 1.20231030.0
workerd --version 1.20231030.0 2023-10-30

|

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@RamIdeas RamIdeas closed this Dec 4, 2023
@RamIdeas RamIdeas reopened this Dec 4, 2023
@RamIdeas
Copy link
Contributor

RamIdeas commented Dec 4, 2023

The Github UI wouldn't let me retry the failed tests so I closed and reopened the PR which seemed to work

Copy link

codecov bot commented Dec 4, 2023

Codecov Report

Merging #3724 (4fb29f9) into main (9f7e547) will increase coverage by 0.51%.
Report is 465 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3724      +/-   ##
==========================================
+ Coverage   74.95%   75.46%   +0.51%     
==========================================
  Files         216      240      +24     
  Lines       12049    12854     +805     
  Branches     3121     3312     +191     
==========================================
+ Hits         9031     9700     +669     
- Misses       3018     3154     +136     
Files Coverage Δ
packages/wrangler/src/index.ts 86.73% <ø> (+3.75%) ⬆️

... and 77 files with indirect coverage changes

@1000hz 1000hz merged commit 609430b into cloudflare:main Dec 11, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants