make the workerd compatibility date retrieval more stable by fetching it directly from the npm registry

[dario-piotrowicz]

It seems like the workerd compatibility retrieval can have some issues with different package managers (or at least with yarn):

• https://github.com/cloudflare/workers-sdk/actions/runs/7211842007/job/19748508606?pr=4602#step:4:65
• https://github.com/cloudflare/workers-sdk/actions/runs/7250601828/job/19751164094?pr=4604#step:4:65
• https://github.com/cloudflare/workers-sdk/actions/runs/7246672804/job/19747293009?pr=4617#step:4:65
• https://github.com/cloudflare/workers-sdk/actions/runs/7246765792/job/19742158656?pr=4618#step:4:65
• https://github.com/cloudflare/workers-sdk/actions/runs/7260941093/job/19781139701?pr=4629#step:4:65

The changes here make this more stable by always using fetching the date directly from the npm registry instead

[changeset-bot]

🦋 Changeset detected

Latest commit: 0a7b06a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
create-cloudflare	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7265806834/npm-package-wrangler-4627

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7265806834/npm-package-wrangler-4627

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7265806834/npm-package-wrangler-4627 dev path/to/script.js

Additional artifacts:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7265806834/npm-package-miniflare-4627

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7265806834/npm-package-cloudflare-pages-shared-4627

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7265806834/npm-package-create-cloudflare-4627 --no-auto-update

Note that these links will no longer work once the GitHub Actions artifact expires.

---

[email protected] includes the following runtime dependencies:

Package	Constraint	Resolved
miniflare	workspace:*	3.20231030.4
workerd	1.20231030.0	1.20231030.0
workerd --version	1.20231030.0	2023-10-30

|

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (98dee93) 75.41% compared to head (0a7b06a) 75.19%.
Report is 10 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4627      +/-   ##
==========================================
- Coverage   75.41%   75.19%   -0.23%     
==========================================
  Files         242      242              
  Lines       12965    13014      +49     
  Branches     3337     3346       +9     
==========================================
+ Hits         9778     9786       +8     
- Misses       3187     3228      +41     

see 13 files with indirect coverage changes

[Skye-31]

Arguably, you could make it more stable by fetching from the NPM registry directly (https://registry.npmjs.org/workerd -> dist-tags -> latest), instead of assuming the user has NPM installed (looking at bun users here)

[petebacondarwin]

Arguably, you could make it more stable by fetching from the NPM registry directly (https://registry.npmjs.org/workerd -> dist-tags -> latest), instead of assuming the user has NPM installed (looking at bun users here)

Good call for bun users... 🤔

Also, does this need to work offline?

[dario-piotrowicz]

Also, does this need to work offline?

I don't think C3 needs to work offline, does it? 🤔
In any case if the date fetch fails then it falls back to 2023-05-18, so I guess that's fine 🙂

workers-sdk/packages/create-cloudflare/src/helpers/command.ts

Line 400 in 421cd58

fallbackOutput: () => "2023-05-18",

[dario-piotrowicz]

Arguably, you could make it more stable by fetching from the NPM registry directly (https://registry.npmjs.org/workerd -> dist-tags -> latest), instead of assuming the user has NPM installed (looking at bun users here)

ok thanks good point I will update it to be a raw fetch 🙂 👍
(can bun users really not have npm installed? 😱 🥲)

[jculvey]

Still LGTM