Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/introduce no-unused-vars and no-shadow eslint rules and also include c3.ts files in linting #4851

Merged
merged 7 commits into from
Jan 29, 2024

Conversation

dario-piotrowicz
Copy link
Member

No description provided.

@dario-piotrowicz dario-piotrowicz requested review from a team as code owners January 28, 2024 15:40
Copy link

changeset-bot bot commented Jan 28, 2024

⚠️ No Changeset found

Latest commit: 12aad09

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Jan 28, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7694660898/npm-package-wrangler-4851

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/4851/npm-package-wrangler-4851

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7694660898/npm-package-wrangler-4851 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7694660898/npm-package-create-cloudflare-4851 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7694660898/npm-package-miniflare-4851
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7694660898/npm-package-cloudflare-pages-shared-4851

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20231218.4
workerd 1.20231218.0 1.20231218.0
workerd --version 1.20231218.0 2023-12-18

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Copy link

codecov bot commented Jan 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (eb76082) 70.70% compared to head (12aad09) 70.74%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4851      +/-   ##
==========================================
+ Coverage   70.70%   70.74%   +0.04%     
==========================================
  Files         291      291              
  Lines       15164    15164              
  Branches     3859     3859              
==========================================
+ Hits        10721    10728       +7     
+ Misses       4443     4436       -7     
Files Coverage Δ
packages/wrangler/src/dev/inspect.ts 6.99% <ø> (ø)
packages/wrangler/src/pages/errors.ts 38.88% <ø> (ø)
.../wrangler/src/pages/functions/routes-validation.ts 83.33% <ø> (ø)
packages/wrangler/src/pages/index.ts 84.00% <100.00%> (ø)
packages/wrangler/src/pages/upload.tsx 78.20% <ø> (ø)

... and 6 files with indirect coverage changes

@dario-piotrowicz dario-piotrowicz changed the title introduce no-unused-vars eslint rule and also include c3.ts files in linting fix/introduce no-unused-vars and no-shadow eslint rules and also include c3.ts files in linting Jan 29, 2024
@@ -67,7 +67,7 @@ const config: TemplateConfig = {
configure,
transformPackageJson: async () => ({
scripts: {
"pages:preview": `${npm} run build && wrangler pages dev .svelte-kit/cloudflare`,
"pages:preview": `${npm} run build && wrangler pages dev ${await compatDateFlag()} .svelte-kit/cloudflare`,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the new no-unused-vars eslint rule made me notice that here we were still importing compatDateFlag but not using it, so I re-added it back here

(PS: no changeset is needed since my changes that remove the flag haven't yet been released)

@dario-piotrowicz dario-piotrowicz merged commit fbd2a4c into main Jan 29, 2024
22 checks passed
@dario-piotrowicz dario-piotrowicz deleted the no-unused-vars branch January 29, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants