-
Notifications
You must be signed in to change notification settings - Fork 803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix/introduce no-unused-vars and no-shadow eslint rules and also include c3.ts files in linting #4851
Conversation
|
0a7b834
to
da1dab5
Compare
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7694660898/npm-package-wrangler-4851 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/4851/npm-package-wrangler-4851 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7694660898/npm-package-wrangler-4851 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7694660898/npm-package-create-cloudflare-4851 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7694660898/npm-package-miniflare-4851 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7694660898/npm-package-cloudflare-pages-shared-4851 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4851 +/- ##
==========================================
+ Coverage 70.70% 70.74% +0.04%
==========================================
Files 291 291
Lines 15164 15164
Branches 3859 3859
==========================================
+ Hits 10721 10728 +7
+ Misses 4443 4436 -7
|
no-unused-vars
eslint rule and also include c3.ts files in linting02662fe
to
12aad09
Compare
@@ -67,7 +67,7 @@ const config: TemplateConfig = { | |||
configure, | |||
transformPackageJson: async () => ({ | |||
scripts: { | |||
"pages:preview": `${npm} run build && wrangler pages dev .svelte-kit/cloudflare`, | |||
"pages:preview": `${npm} run build && wrangler pages dev ${await compatDateFlag()} .svelte-kit/cloudflare`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the new no-unused-vars
eslint rule made me notice that here we were still importing compatDateFlag
but not using it, so I re-added it back here
(PS: no changeset is needed since my changes that remove the flag haven't yet been released)
No description provided.