-
Notifications
You must be signed in to change notification settings - Fork 803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wrangler] Allow empty strings in secret:bulk #4860
[wrangler] Allow empty strings in secret:bulk #4860
Conversation
🦋 Changeset detectedLatest commit: ac9b5d0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7699491551/npm-package-wrangler-4860 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/4860/npm-package-wrangler-4860 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7699491551/npm-package-wrangler-4860 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7699491551/npm-package-create-cloudflare-4860 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7699491551/npm-package-miniflare-4860 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7699491551/npm-package-cloudflare-pages-shared-4860 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
705181a
to
ac9b5d0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks for fixing that. 🙂
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4860 +/- ##
==========================================
+ Coverage 70.70% 70.72% +0.02%
==========================================
Files 291 291
Lines 15164 15165 +1
Branches 3859 3859
==========================================
+ Hits 10721 10725 +4
+ Misses 4443 4440 -3
|
What this PR solves / how to test:
Previously when running
secret:bulk
with asecret.json
containing a variable with an empty string as value the bulk operation would fail. This was due to the check for a falsy value when merging instead of comparing toundefined
to make sure all specified values are excluded. The old other check would keep both the current value and the new value in the merged list which would then be rejected by the settings API as it doesn't allow the same key to be present multiple times.Author has addressed the following:
Note for PR author:
We want to celebrate and highlight awesome PR review! If you think this PR received a particularly high-caliber review, please assign it the label
highlight pr review
so future reviewers can take inspiration and learn from it.