Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add missing defineNavigatorUserAgent dependency to useEsbuild hook #4997

Merged
merged 2 commits into from
Feb 12, 2024

Conversation

dario-piotrowicz
Copy link
Member

In PRs we're getting this eslint warning:
Screenshot 2024-02-12 at 11 54 50

(I think this was introduced in #4499)

This PR adds the missing defineNavigatorUserAgent dependency removing the warning

@dario-piotrowicz dario-piotrowicz requested a review from a team as a code owner February 12, 2024 11:56
Copy link

changeset-bot bot commented Feb 12, 2024

🦋 Changeset detected

Latest commit: f4359f8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
wrangler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@petebacondarwin petebacondarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I spotted this oversight recently too.

Copy link
Contributor

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7871330695/npm-package-wrangler-4997

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/4997/npm-package-wrangler-4997

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7871330695/npm-package-wrangler-4997 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7871330695/npm-package-create-cloudflare-4997 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7871330695/npm-package-cloudflare-kv-asset-handler-4997
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7871330695/npm-package-miniflare-4997
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7871330695/npm-package-cloudflare-pages-shared-4997

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240129.1
workerd 1.20240129.0 1.20240129.0
workerd --version 1.20240129.0 2024-01-29

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Copy link

codecov bot commented Feb 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (05360e4) 70.45% compared to head (f4359f8) 70.48%.
Report is 373 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4997      +/-   ##
==========================================
+ Coverage   70.45%   70.48%   +0.03%     
==========================================
  Files         295      295              
  Lines       15409    15411       +2     
  Branches     3948     3948              
==========================================
+ Hits        10856    10863       +7     
+ Misses       4553     4548       -5     

see 6 files with indirect coverage changes

@dario-piotrowicz dario-piotrowicz merged commit bfeefe2 into main Feb 12, 2024
17 checks passed
@dario-piotrowicz dario-piotrowicz deleted the defineNavigatorUserAgent branch February 12, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants