-
Notifications
You must be signed in to change notification settings - Fork 803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add missing defineNavigatorUserAgent
dependency to useEsbuild hook
#4997
Conversation
🦋 Changeset detectedLatest commit: f4359f8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I spotted this oversight recently too.
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7871330695/npm-package-wrangler-4997 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/4997/npm-package-wrangler-4997 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7871330695/npm-package-wrangler-4997 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7871330695/npm-package-create-cloudflare-4997 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7871330695/npm-package-cloudflare-kv-asset-handler-4997 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7871330695/npm-package-miniflare-4997 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7871330695/npm-package-cloudflare-pages-shared-4997 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4997 +/- ##
==========================================
+ Coverage 70.45% 70.48% +0.03%
==========================================
Files 295 295
Lines 15409 15411 +2
Branches 3948 3948
==========================================
+ Hits 10856 10863 +7
+ Misses 4553 4548 -5 |
In PRs we're getting this eslint warning:

(I think this was introduced in #4499)
This PR adds the missing
defineNavigatorUserAgent
dependency removing the warning