-
Notifications
You must be signed in to change notification settings - Fork 757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support service bindings from Pages projects to workers in a single workerd
instance
#7715
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 67483fb The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
67e5d95
to
08bc217
Compare
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12710649658/npm-package-wrangler-7715 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7715/npm-package-wrangler-7715 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12710649658/npm-package-wrangler-7715 dev path/to/script.js Additional artifacts:cloudflare-workers-bindings-extension: wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12710649658/npm-package-cloudflare-workers-bindings-extension-7715 -O ./cloudflare-workers-bindings-extension.0.0.0-vf8c8eb4d6.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-vf8c8eb4d6.vsix create-cloudflare: npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12710649658/npm-package-create-cloudflare-7715 --no-auto-update @cloudflare/kv-asset-handler: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12710649658/npm-package-cloudflare-kv-asset-handler-7715 miniflare: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12710649658/npm-package-miniflare-7715 @cloudflare/pages-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12710649658/npm-package-cloudflare-pages-shared-7715 @cloudflare/unenv-preset: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12710649658/npm-package-cloudflare-unenv-preset-7715 @cloudflare/vitest-pool-workers: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12710649658/npm-package-cloudflare-vitest-pool-workers-7715 @cloudflare/workers-editor-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12710649658/npm-package-cloudflare-workers-editor-shared-7715 @cloudflare/workers-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12710649658/npm-package-cloudflare-workers-shared-7715 @cloudflare/workflows-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12710649658/npm-package-cloudflare-workflows-shared-7715 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we error helpfully if someone tries to run wrangler dev and one of the provided config files is a pages config?
otherwise very excited about pages going through start_dev!
Added! |
Fixes #5918
As of #7251, Wrangler has supported configuring multiple Workers to run in the same
workerd
instance (with service bindings between them) using multiple-c
flags. However, this didn't work for Pages.This PR adds support for Pages, using the same API as for regular Workers:
wrangler pages dev -c wrangler.toml ../other-worker/wrangler.toml
. However, a slight difference with Pages (compared to regular Workers) is that you can't customise the location of the Pages config file. As such, the first-c
argument must point to the config file for the Pages project, and must be located in the project root. We could've omitted this entirely, but it felt like it would be more confusing to implicitly read a config file that wasn't mentioned—open to dissenting opinions here!This PR also shifts
wrangler pages dev
to usestartDev()
directly rather than going throughunstable_dev()
, opening the door to removingunstable_dev()
entirely in the future.