Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] chore(wrangler): use the unenv preset from @cloudflare/unenv-preset #7720

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

vicb
Copy link
Contributor

@vicb vicb commented Jan 10, 2025

The cloudflare preset was migrated to this mono-repo (@cloudflare/unenv-preset)

This PR is switching to using this version

To do before merging:

  • diff the output of a wrangler build before/after
  • test the pre-release version of wrangler
  • make sure the Vite plugin works with @cloudflare/unenv-preset

/cc @petebacondarwin @pi0 @dario-piotrowicz


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because: preset is tested, will do a diff test
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: no user facing change

@vicb vicb requested a review from a team as a code owner January 10, 2025 09:49
Copy link

changeset-bot bot commented Jan 10, 2025

🦋 Changeset detected

Latest commit: 4bf8ae7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Major
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vicb vicb added the e2e Run e2e tests on a PR label Jan 10, 2025
Copy link
Contributor

github-actions bot commented Jan 10, 2025

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12707935457/npm-package-wrangler-7720

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7720/npm-package-wrangler-7720

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12707935457/npm-package-wrangler-7720 dev path/to/script.js
Additional artifacts:
wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12707935457/npm-package-cloudflare-workers-bindings-extension-7720 -O ./cloudflare-workers-bindings-extension.0.0.0-v883fe2851.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v883fe2851.vsix
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12707935457/npm-package-create-cloudflare-7720 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12707935457/npm-package-cloudflare-kv-asset-handler-7720
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12707935457/npm-package-miniflare-7720
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12707935457/npm-package-cloudflare-pages-shared-7720
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12707935457/npm-package-cloudflare-unenv-preset-7720
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12707935457/npm-package-cloudflare-vitest-pool-workers-7720
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12707935457/npm-package-cloudflare-workers-editor-shared-7720

name2

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12707935457/npm-package-cloudflare-workers-shared-7720

name1

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12707935457/npm-package-cloudflare-workflows-shared-7720

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241230.1
workerd 1.20241230.0 1.20241230.0
workerd --version 1.20241230.0 2024-12-30

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run e2e tests on a PR
Projects
Status: Untriaged
Development

Successfully merging this pull request may close these issues.

1 participant