Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jaeger bindings to asset-worker #7761

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

WillTaylorDev
Copy link
Contributor

This commit adds Jaeger tracing to asset-worker, in order for us to be able to have better insight into failures from KV.


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: n/a
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: n/a

@WillTaylorDev WillTaylorDev requested review from a team as code owners January 14, 2025 15:01
Copy link

changeset-bot bot commented Jan 14, 2025

🦋 Changeset detected

Latest commit: e874fbe

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cloudflare/workers-shared Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@WillTaylorDev WillTaylorDev force-pushed the willtaylor/add-jaeger-asset-worker branch from 5cdec8b to 1c563e3 Compare January 14, 2025 15:06
Copy link
Contributor

github-actions bot commented Jan 14, 2025

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12774489778/npm-package-wrangler-7761

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7761/npm-package-wrangler-7761

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12774489778/npm-package-wrangler-7761 dev path/to/script.js
Additional artifacts:

cloudflare-workers-bindings-extension:

wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12774489778/npm-package-cloudflare-workers-bindings-extension-7761 -O ./cloudflare-workers-bindings-extension.0.0.0-v8d573133a.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v8d573133a.vsix

create-cloudflare:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12774489778/npm-package-create-cloudflare-7761 --no-auto-update

@cloudflare/kv-asset-handler:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12774489778/npm-package-cloudflare-kv-asset-handler-7761

miniflare:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12774489778/npm-package-miniflare-7761

@cloudflare/pages-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12774489778/npm-package-cloudflare-pages-shared-7761

@cloudflare/unenv-preset:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12774489778/npm-package-cloudflare-unenv-preset-7761

@cloudflare/vitest-pool-workers:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12774489778/npm-package-cloudflare-vitest-pool-workers-7761

@cloudflare/workers-editor-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12774489778/npm-package-cloudflare-workers-editor-shared-7761

@cloudflare/workers-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12774489778/npm-package-cloudflare-workers-shared-7761

@cloudflare/workflows-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12774489778/npm-package-cloudflare-workflows-shared-7761

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241230.1
workerd 1.20241230.0 1.20241230.0
workerd --version 1.20241230.0 2024-12-30

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@WillTaylorDev WillTaylorDev force-pushed the willtaylor/add-jaeger-asset-worker branch 2 times, most recently from 63bee1a to 030024f Compare January 14, 2025 16:49
@WillTaylorDev WillTaylorDev force-pushed the willtaylor/add-jaeger-asset-worker branch from 030024f to 3174c52 Compare January 14, 2025 18:09
@WillTaylorDev WillTaylorDev force-pushed the willtaylor/add-jaeger-asset-worker branch from 3174c52 to e874fbe Compare January 14, 2025 18:56
@WillTaylorDev WillTaylorDev merged commit bb85c9a into main Jan 14, 2025
29 checks passed
@WillTaylorDev WillTaylorDev deleted the willtaylor/add-jaeger-asset-worker branch January 14, 2025 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants