Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On KV 404, re-insert with 60s TTL to avoid long 404 cache HITs #7768

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

WalshyDev
Copy link
Member

Fixes N/A

On a 404 from KV, we do not want the asset to stay in cache for the normal 1 year TTL. Instead we want to re-insert with a 30s TTL to revalidate and prevent a bad 404 from persisting.


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: not needed here
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: internal only

@WalshyDev WalshyDev requested review from a team as code owners January 14, 2025 21:36
Copy link

changeset-bot bot commented Jan 14, 2025

🦋 Changeset detected

Latest commit: aa91c4f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cloudflare/workers-shared Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@WalshyDev WalshyDev changed the title On KV 404, re-insert with 30s TTL to avoid long 404 cache HITs On KV 404, re-insert with 60s TTL to avoid long 404 cache HITs Jan 14, 2025
@WalshyDev WalshyDev force-pushed the walshy/fix-asset-404-cache branch from 5d15a04 to d13a734 Compare January 14, 2025 21:47
@WalshyDev WalshyDev force-pushed the walshy/fix-asset-404-cache branch from d13a734 to aa91c4f Compare January 14, 2025 22:11
Copy link
Contributor

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12777293573/npm-package-wrangler-7768

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7768/npm-package-wrangler-7768

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12777293573/npm-package-wrangler-7768 dev path/to/script.js
Additional artifacts:

cloudflare-workers-bindings-extension:

wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12777293573/npm-package-cloudflare-workers-bindings-extension-7768 -O ./cloudflare-workers-bindings-extension.0.0.0-vaa4714fc3.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-vaa4714fc3.vsix

create-cloudflare:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12777293573/npm-package-create-cloudflare-7768 --no-auto-update

@cloudflare/kv-asset-handler:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12777293573/npm-package-cloudflare-kv-asset-handler-7768

miniflare:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12777293573/npm-package-miniflare-7768

@cloudflare/pages-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12777293573/npm-package-cloudflare-pages-shared-7768

@cloudflare/unenv-preset:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12777293573/npm-package-cloudflare-unenv-preset-7768

@cloudflare/vitest-pool-workers:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12777293573/npm-package-cloudflare-vitest-pool-workers-7768

@cloudflare/workers-editor-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12777293573/npm-package-cloudflare-workers-editor-shared-7768

@cloudflare/workers-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12777293573/npm-package-cloudflare-workers-shared-7768

@cloudflare/workflows-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12777293573/npm-package-cloudflare-workflows-shared-7768

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241230.2
workerd 1.20241230.0 1.20241230.0
workerd --version 1.20241230.0 2024-12-30

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@WalshyDev WalshyDev merged commit 97603f0 into main Jan 15, 2025
29 checks passed
@WalshyDev WalshyDev deleted the walshy/fix-asset-404-cache branch January 15, 2025 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants