Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: log the C3 e2e log file to the console when a test fails #7982

Merged
merged 2 commits into from
Feb 3, 2025

Conversation

petebacondarwin
Copy link
Contributor

@petebacondarwin petebacondarwin commented Jan 31, 2025

Hopefully this will help with debugging C3 e2e tests without having to download the log artifact files.
See https://github.com/cloudflare/workers-sdk/actions/runs/13073993617/job/36481629597?pr=7982#step:5:394

Fixes #0000


  • Tests
    • TODO (before merge)
    • Tests included (it is a change to how tests are run)
    • Tests not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: only affects C3 e2e tests
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: just a change to how tests are run

Copy link

changeset-bot bot commented Jan 31, 2025

⚠️ No Changeset found

Latest commit: af07741

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Jan 31, 2025

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13077284865/npm-package-wrangler-7982

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7982/npm-package-wrangler-7982

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13077284865/npm-package-wrangler-7982 dev path/to/script.js
Additional artifacts:

cloudflare-workers-bindings-extension:

wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13077284865/npm-package-cloudflare-workers-bindings-extension-7982 -O ./cloudflare-workers-bindings-extension.0.0.0-vf60bc231b.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-vf60bc231b.vsix

create-cloudflare:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13077284865/npm-package-create-cloudflare-7982 --no-auto-update

@cloudflare/kv-asset-handler:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13077284865/npm-package-cloudflare-kv-asset-handler-7982

miniflare:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13077284865/npm-package-miniflare-7982

@cloudflare/pages-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13077284865/npm-package-cloudflare-pages-shared-7982

@cloudflare/unenv-preset:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13077284865/npm-package-cloudflare-unenv-preset-7982

@cloudflare/vite-plugin:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13077284865/npm-package-cloudflare-vite-plugin-7982

@cloudflare/vitest-pool-workers:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13077284865/npm-package-cloudflare-vitest-pool-workers-7982

@cloudflare/workers-editor-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13077284865/npm-package-cloudflare-workers-editor-shared-7982

@cloudflare/workers-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13077284865/npm-package-cloudflare-workers-shared-7982

@cloudflare/workflows-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13077284865/npm-package-cloudflare-workflows-shared-7982

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20250129.0
workerd 1.20250129.0 1.20250129.0
workerd --version 1.20250129.0 2025-01-29

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@petebacondarwin
Copy link
Contributor Author

Of course all the C3 tests passed first time in CI, so I wasn't able to see what the error logs would have looked like. Will push a commit with a breakage to trigger a failing test...

@petebacondarwin petebacondarwin force-pushed the pbd/improve-c3-e2e-ci-logs branch 2 times, most recently from 2c9e0be to b7e8c34 Compare January 31, 2025 16:18
Hopefully this will help with debugging C3 e2e tests without having to download the log artifact files.
@petebacondarwin petebacondarwin force-pushed the pbd/improve-c3-e2e-ci-logs branch from b7e8c34 to af07741 Compare January 31, 2025 17:01
@petebacondarwin petebacondarwin merged commit b995680 into main Feb 3, 2025
27 checks passed
@petebacondarwin petebacondarwin deleted the pbd/improve-c3-e2e-ci-logs branch February 3, 2025 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants