Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change type to "inherit" for all fetched bindings in versions secret put #8058

Merged

Conversation

WillTaylorDev
Copy link
Contributor

This commit provides a means of inheriting all known bindings, rather than attempting to rebuild them in the versions secret put call. Some bindings (like DOs and internal bindings) don't have all fields returned. Instead, we can provide a type "inherit" for each known binding-by-name, and the API will carry over the binding from the last version.

  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: n/a
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: n/a

@WillTaylorDev WillTaylorDev requested a review from a team as a code owner February 7, 2025 14:36
Copy link

changeset-bot bot commented Feb 7, 2025

🦋 Changeset detected

Latest commit: 9cccbd7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Minor
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Feb 7, 2025

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13207329926/npm-package-wrangler-8058

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/8058/npm-package-wrangler-8058

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13207329926/npm-package-wrangler-8058 dev path/to/script.js
Additional artifacts:

cloudflare-workers-bindings-extension:

wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13207329926/npm-package-cloudflare-workers-bindings-extension-8058 -O ./cloudflare-workers-bindings-extension.0.0.0-ve25f8ae7c.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-ve25f8ae7c.vsix

create-cloudflare:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13207329926/npm-package-create-cloudflare-8058 --no-auto-update

@cloudflare/kv-asset-handler:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13207329926/npm-package-cloudflare-kv-asset-handler-8058

miniflare:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13207329926/npm-package-miniflare-8058

@cloudflare/pages-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13207329926/npm-package-cloudflare-pages-shared-8058

@cloudflare/unenv-preset:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13207329926/npm-package-cloudflare-unenv-preset-8058

@cloudflare/vite-plugin:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13207329926/npm-package-cloudflare-vite-plugin-8058

@cloudflare/vitest-pool-workers:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13207329926/npm-package-cloudflare-vitest-pool-workers-8058

@cloudflare/workers-editor-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13207329926/npm-package-cloudflare-workers-editor-shared-8058

@cloudflare/workers-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13207329926/npm-package-cloudflare-workers-shared-8058

@cloudflare/workflows-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13207329926/npm-package-cloudflare-workflows-shared-8058

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20250129.0
workerd 1.20250204.0 1.20250204.0
workerd --version 1.20250204.0 2025-02-04

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@WillTaylorDev WillTaylorDev force-pushed the willtaylor/bugfix-inherit-bindings-versions-secret-put branch 2 times, most recently from 7efd103 to f85017c Compare February 7, 2025 14:56
@WillTaylorDev WillTaylorDev changed the title Change type to "Inherit" for all fetched bindings in versions secret put Change type to "inherit" for all fetched bindings in versions secret put Feb 7, 2025
@WillTaylorDev WillTaylorDev force-pushed the willtaylor/bugfix-inherit-bindings-versions-secret-put branch from f85017c to 2295e09 Compare February 7, 2025 19:06
@WillTaylorDev WillTaylorDev force-pushed the willtaylor/bugfix-inherit-bindings-versions-secret-put branch from 2295e09 to ad746b8 Compare February 7, 2025 20:08
@WillTaylorDev WillTaylorDev force-pushed the willtaylor/bugfix-inherit-bindings-versions-secret-put branch from ad746b8 to 9cccbd7 Compare February 7, 2025 20:14
@emily-shen emily-shen merged commit 1f80d69 into main Feb 10, 2025
27 checks passed
@emily-shen emily-shen deleted the willtaylor/bugfix-inherit-bindings-versions-secret-put branch February 10, 2025 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants