Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use node 18.20.6 in CI #8060

Merged
merged 1 commit into from
Feb 7, 2025
Merged

chore: use node 18.20.6 in CI #8060

merged 1 commit into from
Feb 7, 2025

Conversation

emily-shen
Copy link
Contributor

@emily-shen emily-shen commented Feb 7, 2025

Currently our C3 tests are failing as unimport requires node >= 18.20.6.
We are currently on 18.20.5 so this shouldn't have much impact.


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because: pass existing
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: internal

@emily-shen emily-shen requested a review from a team as a code owner February 7, 2025 15:55
Copy link

changeset-bot bot commented Feb 7, 2025

⚠️ No Changeset found

Latest commit: 44fccca

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@emily-shen emily-shen added no-changeset-required e2e Run wrangler e2e tests on a PR labels Feb 7, 2025
Copy link
Contributor

github-actions bot commented Feb 7, 2025

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13203360352/npm-package-wrangler-8060

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/8060/npm-package-wrangler-8060

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13203360352/npm-package-wrangler-8060 dev path/to/script.js
Additional artifacts:

cloudflare-workers-bindings-extension:

wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13203360352/npm-package-cloudflare-workers-bindings-extension-8060 -O ./cloudflare-workers-bindings-extension.0.0.0-vd204b0ee3.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-vd204b0ee3.vsix

create-cloudflare:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13203360352/npm-package-create-cloudflare-8060 --no-auto-update

@cloudflare/kv-asset-handler:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13203360352/npm-package-cloudflare-kv-asset-handler-8060

miniflare:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13203360352/npm-package-miniflare-8060

@cloudflare/pages-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13203360352/npm-package-cloudflare-pages-shared-8060

@cloudflare/unenv-preset:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13203360352/npm-package-cloudflare-unenv-preset-8060

@cloudflare/vite-plugin:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13203360352/npm-package-cloudflare-vite-plugin-8060

@cloudflare/vitest-pool-workers:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13203360352/npm-package-cloudflare-vitest-pool-workers-8060

@cloudflare/workers-editor-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13203360352/npm-package-cloudflare-workers-editor-shared-8060

@cloudflare/workers-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13203360352/npm-package-cloudflare-workers-shared-8060

@cloudflare/workflows-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13203360352/npm-package-cloudflare-workflows-shared-8060

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20250129.0
workerd 1.20250204.0 1.20250204.0
workerd --version 1.20250204.0 2025-02-04

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@lrapoport-cf lrapoport-cf added the caretaking Priority for caretaking label Feb 7, 2025
@emily-shen emily-shen merged commit 7c05b1b into main Feb 7, 2025
37 of 41 checks passed
@emily-shen emily-shen deleted the emily/bump-node branch February 7, 2025 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
caretaking Priority for caretaking e2e Run wrangler e2e tests on a PR no-changeset-required
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants