Add metric tags to task definition #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove unnecessary task declaration in task model test and only use JSON representation. Signed-off-by: Rebecca Roberts <[email protected]>
This was referenced Dec 19, 2023
MarcPaquette
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this change about?
Adds metric tags to tasks.
What problem it is trying to solve?
Operator wants to see app/space/org names in task logs.
What is the impact if the change is not made?
No consistency between LRP and task logs in regards to tags.
How should this change be described in diego-release release notes?
Task logs include tags.
Please provide any contextual information.
cloudfoundry/rep#50
Tag your pair, your PM, and/or team!
@mkocher
Thank you!