-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update warden stage to support Noble #397
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jpalermo
commented
Nov 26, 2024
- Enable systemd in the container
- Remove all runit shims that were previously included because systemd was not being used
- local_events must be disabled for auditd due to running in a container
- systemd DefaultStartLimitBurst must be increased because some services are restarted more than 5 times in 5 seconds on agent startup (systemd-resolvd was seen at least)
- Disable pam_faillock module. This was a differnet pam module in Jammy and prior. It's used to show number of previous failed login attempts. It seems that when it's enabled within a container sshd is unable to properly tracker users and causes ssh-ing into the container to fail.
- Enable systemd in the container - Remove all runit shims that were previously included because systemd was not being used - local_events must be disabled for auditd due to running in a container - systemd DefaultStartLimitBurst must be increased because some services are restarted more than 5 times in 5 seconds on agent startup (systemd-resolvd was seen at least) Signed-off-by: Joseph Palermo <[email protected]> Co-authored-by: Joseph Palermo <[email protected]>
jpalermo
force-pushed
the
pr-noble-warden-fixes
branch
from
November 28, 2024 06:38
3ca5ff7
to
d4d86af
Compare
Closed
rkoster
requested review from
ramonskie,
a team and
ystros
and removed request for
a team
November 28, 2024 16:08
ystros
previously approved these changes
Dec 2, 2024
aramprice
previously approved these changes
Dec 4, 2024
ramonskie
previously approved these changes
Dec 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested it and work
beyhan
approved these changes
Dec 5, 2024
ramonskie
approved these changes
Dec 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.