bump fog openstack gem to new version 1.1.1 & enable application credential authentication #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmoehler
changed the title
mvach
reviewed
May 15, 2024
| @@ -778,6 +782,20 @@ def validate_options | |||
| }, | |||
| optional('agent') => Hash, | |||
| } | |||
|
|
|||
| unless ((username && api_key) || (application_credential_id && application_credential_secret)) || | |||
| (username && api_key && application_credential_id && application_credential_secret) | |||
There was a problem hiding this comment.
What do we check with (username && api_key && application_credential_id && application_credential_secret) ?
Finally all of the properties must not be nil?
There was a problem hiding this comment.
We wanted to check that not all of these credentials are provided.
There was a problem hiding this comment.
But then it should be
unless ((username && api_key) || (application_credential_id && application_credential_secret)) &&
!(username && api_key && application_credential_id && application_credential_secret)
There was a problem hiding this comment.
Agree, may be splitting this into two boolean variables make it more readable?
e.g.: using_api_key = username && api_key?
fearoffish
force-pushed
the
bump-fog-openstack-gem
branch
from
5429e79 to
f416866
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.