Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bumped dependencies for nats-pure and ruby-prof to the most recent versions #2476

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

AttilaAlmasi
Copy link
Contributor

What is this change about?

Update outdated dependencies for ruby-prof and nats-pure.

Internal Blackduck scans found some very outdated libs in the upstream bosh director.

Please provide contextual information.

https://cloudfoundry.slack.com/archives/C02HPPYQ2/p1698155192619889

What tests have you run against this PR?

How should this change be described in bosh release notes?

bumped dependencies for nats-pure and ruby-prof to the most recent versions

Does this PR introduce a breaking change?

Tag your pair, your PM, and/or team!

@fmoehler

Copy link

linux-foundation-easycla bot commented Nov 3, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

@mvach mvach self-requested a review November 7, 2023 09:18
@mvach
Copy link
Contributor

mvach commented Nov 7, 2023

Looks good to me let's see what pipelines will tell.

@jpalermo
Copy link
Member

jpalermo commented Nov 7, 2023

If we're bumping to the latest, lets just remove the version spec entirely so it will auto bump in the future.

Could you also revert the platform change from x86_64-darwin-22 to ruby. I'm not really sure what that does (if anything), but we probably don't want the committed one to be a "darwin" string.

@AttilaAlmasi
Copy link
Contributor Author

Hello @jpalermo
thank you for your review. We just pushed a change fixing your suggestions.

Copy link
Contributor

@anshrupani anshrupani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@jpalermo
Copy link
Member

jpalermo commented Nov 8, 2023

Looks great. Thanks!

Right now it won't let me merge the PR because of conflicts (probably from our automated bumps of Gems). Could you rebase it and I'll get it merge in?

@AttilaAlmasi
Copy link
Contributor Author

Hello @jpalermo,
rebase is done and I think we can merge it now.

@jpalermo jpalermo merged commit 342485b into cloudfoundry:main Nov 9, 2023
@jpalermo
Copy link
Member

jpalermo commented Nov 9, 2023

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

4 participants