docker in docker service fails to start #2493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docker/cli#4807 As of 02/01/2024 a change in the "/etc/init.d/docker" script shipped with docker v25 is preventing the cpi image to work. when start-bosh runs `service docker start` it errors with: "/etc/init.d/docker: 62: ulimit: error setting limit (Invalid argument)" Workaround recommended in github issue suggests to disable resetting ulimit. Pre v25 the script contained `ulimit -n 1048576`, with v25 it changed to: `ulimit -Hn 524288`. the default in our base image is: ulimit -a | grep file `open files (-n) 1048576` so it was a noOp before the change shipped with v25 of docker to confirm I tried running `ulimit -Hn 1048576` and it will succeed.. The issue happens when we want to actually change the ulimit. In our case it would attempt to lower it and it's probably fine not doing that in CI?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docker/cli#4807
As of 02/01/2024 a change in the "/etc/init.d/docker" script shipped with docker v25 is preventing the cpi image to work.
when start-bosh runs
service docker startit errors with: "/etc/init.d/docker: 62: ulimit: error setting limit (Invalid argument)"Workaround recommended in github issue suggests to disable resetting ulimit.
Pre v25 the script contained
ulimit -n 1048576, with v25 it changed to:ulimit -Hn 524288.the default in our base image is:
ulimit -a | grep file
open files (-n) 1048576so it was a noOp before the change shipped with v25 of docker
to confirm I tried running
ulimit -Hn 1048576and it will succeed..The issue happens when we want to actually change the ulimit. In our case it would attempt to lower it and it's probably fine not doing that in CI?
What is this change about?
Describe the change and why it's needed.
Please provide contextual information.
Include any links to other PRs, stories, slack discussions, etc... that will help establish context.
What tests have you run against this PR?
Include a comprehensive list of all tests run successfully.
How should this change be described in bosh release notes?
Something brief that conveys the change and is written with the Operator audience in mind.
See previous release notes for examples.
Does this PR introduce a breaking change?
Does this introduce changes that would require operators to take care in order to upgrade without a failure?
Tag your pair, your PM, and/or team!
It's helpful to tag a few other folks on your team or your team alias in case we need to follow up later.