Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add v5 endpoint for drain-controller to nginx.conf #272

Merged
merged 2 commits into from
Sep 28, 2022

Conversation

fhambrec
Copy link
Contributor

@fhambrec fhambrec commented Sep 27, 2022

This change opens a new endpoint in the nginx.conf that was added to the internal syslog_drain_controller lately.
The PR that introduces the new endpoint can be found here.

  • I have viewed signed and have submitted the Contributor License Agreement

  • I have made this pull request to the develop branch

  • I have run CF Acceptance Tests on bosh lite

Copy link
Member

@philippthun philippthun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This new endpoint should be forbidden for external clients, as it's done for /internal/v4/.

# Forbid access to internal endpoints
location /internal/v4/ {
return 403 'Forbidden';
}

@philippthun philippthun merged commit 7a99ee2 into cloudfoundry:develop Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants